spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Implement HttpClient based Zipkin sender

Open mhalbritter opened this issue 1 year ago • 3 comments

Currently, we have 3 Zipkin senders:

  • URLConnectionSender, needs zipkin-sender-urlconnection
  • RestTemplate based one, needs spring-web
  • WebClient based one, needs spring-webflux

With the changes in #39049, the webclient one will likely be removed, as the Zipkin sender interface is no longer async by default and we have to call block.

We should implement a JDK HttpClient based sender, which can be used without any dependencies.

mhalbritter avatar Feb 14 '24 13:02 mhalbritter

Some WIP in https://github.com/mhalbritter/spring-boot/tree/mh/39545-implement-httpclient-based-zipkin-sender.

mhalbritter avatar Feb 14 '24 13:02 mhalbritter

I wonder if we should only provide an HttpClient-based sender. It would simplify things a little and give us less code to maintain if we got rid of the other two as well as the WebClient-based one.

wilkinsona avatar Feb 14 '24 14:02 wilkinsona

Yeah, I think that's a good idea. I'll try to get the HttpClient sender into 3.3.x and then we can deprecate the other ones.

mhalbritter avatar Feb 14 '24 15:02 mhalbritter

Blocked until #39049 is merged.

mhalbritter avatar Feb 20 '24 10:02 mhalbritter

this is great. looking forward to the removal of the other senders!

codefromthecrypt avatar Mar 09 '24 05:03 codefromthecrypt