spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

moveToSnapshots logs an upgrade to a version that does not exist yet

Open snicoll opened this issue 1 year ago • 4 comments

When moveToSnapshots is used, it logs the same thing than an actual upgrade, e.g.

Upgrade to Spring Framework 5.3.28

However, that's not really what it has done. While it has created an issue with that title, it really switched the build to use 5.3.28-SNAPSHOT. I wonder if the log could be rephrased, something like:

Start building against Spring Framework 5.3.28 snapshots

snicoll avatar May 05 '23 06:05 snicoll

I'm not sure what happened here as it should already do that:

https://github.com/spring-projects/spring-boot/blob/56af1569d3edde34d12ff9ba49b5810bca544f1e/buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/MoveToSnapshots.java#L49-L53

This commit was generated by Bomr and the commit message looks good to me.

wilkinsona avatar May 05 '23 07:05 wilkinsona

The commit message is not what I am talking about here. I mean the log statement in the console.

snicoll avatar May 05 '23 07:05 snicoll

Ah, I see. I thought you meant the commit log not the console log.

The current logging is describing the issues that have been opened. In addition to the issue title, it will also tell you if an issue supersedes an existing upgrade or if we're completing an upgrade where we previously moved to snapshots:

https://github.com/spring-projects/spring-boot/blob/56af1569d3edde34d12ff9ba49b5810bca544f1e/buildSrc/src/main/java/org/springframework/boot/build/bom/bomr/UpgradeDependencies.java#L104-L117

Perhaps we should add to this and suffix the issue title with something that indicates we're moving to snapshots for the upgrade.

wilkinsona avatar May 05 '23 08:05 wilkinsona

The current logging is describing the issues that have been opened.

Yes, but in the context of what it actually does, I find that misleading. I don't know what suffix could help with that though.

snicoll avatar May 05 '23 09:05 snicoll