spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Documenting audience support in Oauth2 resource server

Open bikash30851 opened this issue 2 years ago • 3 comments

Closes #34848

bikash30851 avatar May 04 '23 16:05 bikash30851

@bikash30851 Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar May 04 '23 16:05 pivotal-cla

@bikash30851 Thank you for signing the Contributor License Agreement!

pivotal-cla avatar May 04 '23 16:05 pivotal-cla

@snicoll I have completed the documentation for issue #34848. Feel free to make suggestions. Thank you

bikash30851 avatar May 04 '23 16:05 bikash30851

Can you squash commits to one clean commit? Having multiple commits is good during development but spoils the commit history. I am unsure if the package has rules to squash during a merge.

at758 avatar May 07 '23 03:05 at758

@at758, thanks for trying to help but if we wanted the commits to be squashed we would ask @bikash30851 to so do.

@bikash30851, your commits are fine as they are. If necessary when can squash them as part of merging your pull request.

wilkinsona avatar May 07 '23 07:05 wilkinsona

Thank you for your review. I have incorporated your feedback into the documentation. @wilkinsona

bikash30851 avatar May 09 '23 14:05 bikash30851

@wilkinsona do I need to do anything else for this PR to be merged? Thank you!

bikash30851 avatar May 23 '23 16:05 bikash30851

@bikash30851 Thanks very much for making your first contribution to Spring Boot.

wilkinsona avatar May 25 '23 13:05 wilkinsona