spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

Add path to details and log message

Open rreich opened this issue 3 years ago • 1 comments
trafficstars

Directly seeing the path would make it easier for developers and administrators to find and fix a configuration issue.

rreich avatar Aug 08 '22 08:08 rreich

@rreich Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Aug 08 '22 08:08 pivotal-cla

@rreich thanks for the PR we can't proceed until you've signed the CLA.

snicoll avatar Aug 10 '22 07:08 snicoll

@rreich Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Aug 10 '22 10:08 pivotal-cla

@snicoll Thanks for looking at the PR and for the hint. I hoped this might be considered an "obvious fix". I signed the CLA now.

rreich avatar Aug 10 '22 10:08 rreich

@rreich Thanks very much for making your first contribution to Spring Boot.

wilkinsona avatar Sep 05 '22 12:09 wilkinsona

Thanks @wilkinsona ! Unfortunately I just noticed that you seem to integrate fixes upwards, so I should have probably created this PR against 2.6.x (The version we are using currently). I created a new PR for that now by cherry-picking from main: https://github.com/spring-projects/spring-boot/pull/32234 Sorry for my misunderstanding - I should have checked beforehand. If it is too much of an inconvenience, feel free to close the new PR.

rreich avatar Sep 05 '22 16:09 rreich

No problem. As Brian explained on #32234, this isn't the sort of change that we'd make in a maintenance release anyway. It's not fixing a bug so it belongs in the next major or minor release. That's 3.0 at this time.

wilkinsona avatar Sep 05 '22 17:09 wilkinsona