spring-boot icon indicating copy to clipboard operation
spring-boot copied to clipboard

Add builder docker host option for image building

Open scottfrederick opened this issue 3 years ago • 4 comments

Add support for configuring the address of the Docker daemon that processes running in the CNB builder container should use.

In the Maven plugin image configuration, the option could look like this:

<configuration>
	<image>
		<builderDockerHost>tcp://127.0.0.1:2375</builderDockerHost>
	</image>
</configuration>

In the Gradle plugin bootBuildImage configuration, the option could look like this:

bootBuildImage {
    builderDockerHost = "tcp://127.0.0.1:2375"
}

scottfrederick avatar Apr 02 '21 16:04 scottfrederick

Hello! Any plans for this improvement to make it's way in soon? I cant use Spring Boot image building without it unfortunately.

astropcr avatar Jan 26 '22 05:01 astropcr

@astropcr We don't have any immediate plans to add this feature, as indicated by the fact that it is assigned to the 2.x backlog.

We have recently identified an issue that is related to this. The Spring Boot plugins should configure the builder container to use the same Docker host that Spring Boot is using, but we currently aren't doing that. Would the fix for the other issue address your needs, or do you have a requirement to configure the Docker host used by the build container to be different from the one used by Spring Boot plugins?

scottfrederick avatar Jan 26 '22 13:01 scottfrederick

thanks @scottfrederick - that would do the trick actually. Is there a link to that issue I can track?

Thanks

astropcr avatar Jan 26 '22 20:01 astropcr

@astropcr The issue is linked with hypertext in the comment above, but the direct link is #29384.

scottfrederick avatar Jan 26 '22 20:01 scottfrederick