spring-batch icon indicating copy to clipboard operation
spring-batch copied to clipboard

Published 20 hours ago • verified publisher icon spring-projects

[BATCH-2767] Fixing and refactoring SynchronizedItemStreamReaderTests

Open dimitrisli opened this issue 6 years ago • 2 comments

along with its builder test class SynchronizedItemStreamReaderBuilderTests

dimitrisli avatar Oct 30 '18 22:10 dimitrisli

Hi @dimitrisli , thank you for this PR!

Before addressing your changes, I was looking at the current test of the synchronized reader, and I feel like it's testing the synchronized modifier of Java. I really trust the JVM here on synchronizing access to the read method and I wouldn't bother starting multiple threads and making sure only one of them is calling the method at a time..

We had a similar discussion on the synchronized writer side on which we agreed, so could you please update this PR similarly to what we did for the writer? Please do not hesitate to update the year in license headers as well. Thank you upfront!

fmbenhassine avatar May 15 '20 10:05 fmbenhassine

Hi @dimitrisli ,

Did you get a chance to check my previous comment? If you can't update the PR, let me know if you agree and I will take care of the changes.

Thank you.

fmbenhassine avatar Aug 11 '20 08:08 fmbenhassine

Rebased, squashed and merged as f0787454f875d6b71869ba69d023d2d731206139. I also refactored the test as mentioned in my previous comments.

Thank you for your contribution!

fmbenhassine avatar Jun 12 '23 12:06 fmbenhassine