spring-aot-smoke-tests icon indicating copy to clipboard operation
spring-aot-smoke-tests copied to clipboard
verified publisher icon spring-projects

[WIP] Enhance cloud-stream-rabbit/kafka tests

Open onobc opened this issue 2 years ago • 1 comments

  • Add multi-binder with complex property for rabbit
  • Add complex property for kafka

[DependsOn] https://github.com/spring-cloud/spring-cloud-stream/pull/2712

See https://github.com/spring-cloud/spring-cloud-stream/issues/2690

cc: @sobychacko

onobc avatar Apr 18 '23 05:04 onobc

@onobc Looks good to me.

sobychacko avatar Apr 18 '23 13:04 sobychacko

What's the status of this, @onobc? The title marks it as a work in progress but it looks like the PR that it depends upon has been merged. Can this PR be merged now too?

wilkinsona avatar May 15 '24 12:05 wilkinsona

@wilkinsona it dropped off my radar. I will take a look w/in the next 12hrs and let you know the status. Thanks for the ping.

onobc avatar May 15 '24 18:05 onobc

@wilkinsona

  • rebased
  • ran :integration:spring-kafka:build and integration:spring-amqp-rabbit:build with success

Should be ready for review/merge.

onobc avatar May 16 '24 03:05 onobc

Thanks, @onobc. What branches can this go in? https://github.com/spring-cloud/spring-cloud-stream/commit/3990bb485e63a86df8a074e8034a74b11a29cc4b went in Spring Cloud Stream 4.0.x so it looks like it could go right the way back to 3.0.x, correct?

wilkinsona avatar May 16 '24 11:05 wilkinsona

I believe that is correct @wilkinsona . Let me know if you need me to retarget another branch etc..

onobc avatar May 16 '24 14:05 onobc

All good. Thanks, @onobc. This is now in 3.0.x and merged forwards through 3.1.x, 3.2.x, and into main.

wilkinsona avatar May 17 '24 11:05 wilkinsona