spring-ai icon indicating copy to clipboard operation
spring-ai copied to clipboard

Consider categorising the ChatOptions into Model and Request category of options

Open tzolov opened this issue 1 year ago • 0 comments
trafficstars

  • For example the OllamaOptions class contains Ollama options properties as well as non-model related options such as format, model, keep-alive used for call request creation. Later are filtered out explicitly before the request is made.
  • Similarly the Function Calling related properties are added to the corresponding ModelXOptions but marked as @JsonIgnore so they again are filtered before passing the options to the call. ...

A proper separation for model and request sub-category in the ModelXOptions would make the management cleaner and easier.

tzolov avatar Apr 04 '24 15:04 tzolov