Add username and password authentication to GemFire VectorStore
Thank you for taking time to contribute this pull request! You might have already read the contributor guide, but as a reminder, please make sure to:
- Add a Signed-off-by line to each commit (
git commit -s) per the DCO - Rebase your changes on the latest
mainbranch and squash your commits - Add/Update unit tests as needed
- Run a build and make sure all tests pass prior to submission
For more details, please check the contributor guide. Thank you upfront!
Hi @jhuynh1,
thanks for your valuable contribution, which seems good on first read. However, there is no need to test queries with both form of authentication.
Could you please refactor the tests section of your PR to test (only) both authentication mechanisms in a test class, and leave the queries aspects in another (existing) test?
Hi @ericbottard ,
I've reverted the test to return back to it's original form and added the two authentication tests to test only a few operations.
There was also new changes to the docs and to auto configuration
I've added/readded the disabled annotation as it was present before, but ran the tests locally before doing so. I think it was disabled because there was some issues with pulling the gemfire image for some reason.
Thanks!
This PR is now merged to main and backported to 1.1.x.