spring-ai
spring-ai copied to clipboard
EPIC - Removing deprecated code
trafficstars
The next release is RC1 which will not have any @Deprecated code. There is not another M8 to allow users one more release cycle to upgrade. So some changes such as
https://github.com/spring-projects/spring-ai/commit/1f59ccadad13f007f07a2389edc33923b6d710ea
wrt to Advisors will be breaking changes. This needs to be clearly communicate in upgrade-notes.adoc
This is the fine grained list of what deprecated code needs to be removed.
Large Effort
- [ ] CallAroundAdvisor needs to be removed and code updated. So does usage of AdvisedRequest, AdvisedResponse - > use ChatClientRequest and ChatClientResponse [Post M8]
Medium Effort
- [ ] Ctors for UserMessage (To discuss: should we add builder for other Message implementations?) [Post M8]
- [ ] All the classes in the model.function package. This requires minimax and potentially zhipu refactoring. [In M8]
- [ ] OpenAiApi - ChatCompletionRequest - check about useage of max_tokens, other OpenAI API compatibly libraries may still use it. [In M8]
- [ ] https://github.com/spring-projects/spring-ai/issues/2518 [In M8]
Low Effort
- [x] ContentFormatter was listed as deprecated, but we are going to keep it.
- [ ] ChatModelObservationContext - remove getRequestOptions [In M8] #2518
- [ ] Same as above for Embedding and Image modelobservationcontext. [In M8] #2518
- [ ] ToolCallback [In M8]
- [x] AnthropicApi - left over 'with' Builder methods.
- [x] VertexAiGeminiChatOptions - some simple left over methods.
- [x] Deprecated test methods in ITs, e.g. BedrockProxyChatModelIT - need to make sure there are equivalents in the updated API.
- [x] SimpleVectorStoreContent
Update examples in our exmaples repo.
- [ ] Move to snapshot and rebuilt the examples.