spring-ai
spring-ai copied to clipboard
Fix: MiniMax model function call
PR content: fix MiniMax model function call and unit tests.
Most scenarios has worked, but in some complex situations within the English context, if there are multiple rounds of function calls, there's a certain probability they might stop prematurely. For example, when trying to get the weather for multiple locations at once, but the function for getting the weather only accepts a single location as a parameter. This is mainly limited by the model's performance.
related issue: https://github.com/spring-projects/spring-ai/issues/1077
HI @mxsl-gr and thank you for the update.
As we are deprecating AbstractFunctionCallSupport in favor of AbstractToolCallSupport would you be interested to re-work your PR to support AbstractToolCallSupport?
For examples, you can check the OpenAI/AzureOpenAI/Anthropic/Mistral/Ollama/VertexAIGemini function calling implementations, or ask me for support ;) Would appreciate your help as you own those models.
hi, no problem, i'll check and handle them later
hi, @tzolov it worked for now, and this PR has been squash and force pushed
some issues in streaming, but as with the other PRs you made, it is better to get this in as it is a big step forward.
Thanks and apologies for the delay.
merged in 0927bd197db7ed4f8ac7fa7d99c9cbfdc24b3c27
some issues in streaming, but as with the other PRs you made, it is better to get this in as it is a big step forward.
Thanks and apologies for the delay.
merged in 0927bd1
thanks for you merged my PR, when i committed this PR, all tests passed. i will check it out later to see what the problem is