spring-boot-migrator icon indicating copy to clipboard operation
spring-boot-migrator copied to clipboard

adding the jmx endpoint exposure related files .

Open ishu-thakur opened this issue 3 years ago • 2 comments

ishu-thakur avatar Oct 08 '22 20:10 ishu-thakur

@ishu-thakur Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Oct 08 '22 20:10 pivotal-cla

@ishu-thakur Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Oct 08 '22 20:10 pivotal-cla

Thank you @ishu-thakur for this contribution 🚀

Thank you @fabapp2 for giving me this chance and helping me out throughout and if help required or any other issue I am always open for it :)

ishu-thakur avatar Nov 03 '22 18:11 ishu-thakur

Thank you @ishu-thakur for this contribution 🚀

Thank you @fabapp2 for giving me this chance and helping me out throughout and if help required or any other issue I am always open for it :)

Hi @ishu-thakur

You're very welcome. I am glad you are contributing 🤩 No offense, I moved the recipe to the "other" yaml myself as I want to get all PRs to main (trying to catch up). I was not sure about your time and thought I'd do the little change myself to get your PR merged back. Got into some merge conflicts with other stuff, that's why I am pushing changes to your PR right now...

fabapp2 avatar Nov 03 '22 18:11 fabapp2

Got into some merge conflicts with other stuff,

@fabapp2 if you need any help or is there anything I can do I will love to do it .

ishu-thakur avatar Nov 03 '22 18:11 ishu-thakur

Got into some merge conflicts with other stuff,

@fabapp2 if you need any help or is there anything I can do I will love to do it .

@ishu-thakur I'd say let me finish the mess I started. But if you want to look into something else #248 will be the next important issue. If you like you can read into it, the description is rather incomplete but if you add a comment there that you'd like to pick it we can have a conversation about what to do and how to split work there?

fabapp2 avatar Nov 03 '22 18:11 fabapp2

o split work there?

@fabapp2 that sounds awesome to me . Sure we can split work there and let me go through the documentation .

ishu-thakur avatar Nov 03 '22 18:11 ishu-thakur