spring-petclinic-reactjs icon indicating copy to clipboard operation
spring-petclinic-reactjs copied to clipboard
verified publisher icon spring-petclinic

Customize GitHub language detection

Open arey opened this issue 8 years ago • 5 comments

GitHub uses linguist to detect languages. For spring-petclinic-reactks, CSS is the first one. It should be Java or TypeScript. We could customize this behavior, See https://github.com/spring-petclinic/spring-petclinic-kotlin/blob/master/.gitattributes

arey avatar Dec 01 '17 10:12 arey

@arey I can send in a pull request for this change, seems pretty straightforward. Anything specific I should take care of? Thanks !!

ankurshukla10 avatar Dec 09 '20 14:12 ankurshukla10

Hi @ankurshukla10 , sure, you could submit a change. If you want to upgrade this sample to more recent versions of Spring Boot and ReactJS, you're welcome.

image

arey avatar Dec 09 '20 15:12 arey

After your PR merge, the languages repartition didn't changed and I don't know why :-(

arey avatar Dec 10 '20 07:12 arey

@arey yeah, I noticed too :(. I am trying to check this locally by installing github-linguist on my development machine, but to my bad luck the install keeps on failing. Right now I am getting the attached error. Do you have any insights on why that might be? Or If you can point me in a better direction, that'll be helpful.

Machine-Processor: Intel(R) Core(TM) i7-8665U CPU @ 1.90GHz, 2112 Mhz, 4 Core(s), 8 Logical Processor(s) OS Name: Microsoft Windows 10 Pro (Version-10.0.19041 Build 19041) Ruby Version: ruby 2.6.5p114 (2019-10-01 revision 67812) [x64-mingw32] Gem Version: 3.0.3

github-linguist-install-fails.txt

ankurshukla10 avatar Dec 10 '20 08:12 ankurshukla10

Maybe you have to install a ruby gem?

gem install ffi -- --enable-system-libffi        # to install the gem manually
bundle config build.ffi --enable-system-libffi   # for bundle install

See https://github.com/ffi/ffi

arey avatar Dec 12 '20 10:12 arey