tut-react-and-spring-data-rest
tut-react-and-spring-data-rest copied to clipboard
spring-guides
Fixes frontend-maven-plugin snippet in `basic` module.
It looks like, to maintain sanity, the configuration for the
frontend-maven-plugin was defined in the root tutorial pom and the
configuration is inherited by all the submodules, like basic.
The problem was that one following along with the project needs that configuration.
Now, we show the full configuration instead by including the
frontend-maven-plugin configuration from the root POM instead of
from basic's POM.
Should resolve some concerns described in issues #124, #128.
It makes sense why there's been some people confused about this plugin.
What they were seeing:
What they needed to be seeing:
Can you think of anything that would stop this PR from being merged?
@gregturn Well this actually fixes nothing i dont even see any relevant file being commited... But what needs to be fixed so in basic and other modules will frontend:install-node-and-npm goal work in Idea is that in main pom.xml must nodeVersion and npmVersion tags be moved to upper plugin configuration section just where <installDirectory>target</installDirectory> resides. I dont get it why you didnt tested it, or does it work from plain mvn commandline? Anyway great tutorial but this is broken.
Is this PR still being considered? It would be extremely helpful to update the Spring Guide: Accessing JPA Data with REST with this change. Thank you!
