gs-testing-restdocs icon indicating copy to clipboard operation
gs-testing-restdocs copied to clipboard

A proofread turned shipwreck

Open UgmaDevelopment opened this issue 5 years ago • 4 comments

Having never done Spring RestDocs, I thought I'd give it a try and fix anything I came across.

I started to fixed a few unclear portions, but then I ran into many broken things in the tutorial and had to abandon ship. Though I thought it would helpful to pass along the few fixes I did make.

It appears that this tutorial needs to be reworked. @Buzzardo it seems you may have accidentally broken some things around commit 42f92f241cfd162598bf8fa5fcb5641bd5222a92. I agree with you that this tutorial should be updated to use a more recent template from Spring Initializr. There's a violation of expectations, however, when you start off with just the Web starter and then end up with many more dependencies and configuration that appears out of nowhere, without any instruction. I think the simplest way to go about this would be to start off having all the dependencies included by Spring Initializr—perhaps RestDocs didn't use to be in the Initializr, but it is now—after all, that's what it's for, right?

I think starting off with Web and RestDocs as dependencies would simplify the changes that need to be made to make this tutorial workable again.

Thanks for all the hard work that's gone into this so far. I'd be happy to test out any future changes for continuity, with my naïve eyes.

UgmaDevelopment avatar Dec 11 '20 21:12 UgmaDevelopment

Thanks for the updates. I made a few comments. I'm sorry you gave up because it all works for me.

dsyer avatar Dec 12 '20 07:12 dsyer

Thanks for the updates. I made a few comments. I'm sorry you gave up because it all works for me.

🤔 I'm curious if you followed along from the beginning of the tutorial or if you jumped to the end. I'd be willing to bet that the finished code is indeed functional. However, it appears that most Spring tutorials allow readers two ways of completing them:

  1. by following along from the beginning
  2. jumping to the part where it already works

My concern in this tutorial is with the first: the beginning doesn't appear to lead you very well to the end.

UgmaDevelopment avatar Dec 14 '20 18:12 UgmaDevelopment

I've started a separate pull request (#11) regarding an effort to make it so that one could follow along from the beginning of the tutorial. It's not done, but feel free to make suggestions or additions.

Thanks!

UgmaDevelopment avatar Dec 14 '20 18:12 UgmaDevelopment

Yes, we do try to offer two paths: One that walks the reader through each step and one that lets them jump to a completed project. We want both to be right, of course. We also want the tutorial to be as easy to follow as possible. We really appreciate when the community takes the time to test the tutorial and give us feedback, as you've done here. As with anything else, we can get only so far by ourselves. A good review gets us much further along. Thanks much.

Buzzardo avatar Dec 14 '20 19:12 Buzzardo