mia
mia copied to clipboard
Wrong parameter order in BaseModelSerializer
Hi,
In the BaseModelSerializer
definition, the Keras model is passed before the model ID:
https://github.com/spring-epfl/mia/blob/d389d30188ca115d21365f5b0595b1bb5f1bbee9/mia/serialization.py#L29
But in the ShadowModelBundle
class the model ID is passed before the model object:
https://github.com/spring-epfl/mia/blob/d389d30188ca115d21365f5b0595b1bb5f1bbee9/mia/estimators.py#L118
I think the BMS abstract class definition should be corrected with the two arguments swapped in order.
Best