spring-cloud-vault icon indicating copy to clipboard operation
spring-cloud-vault copied to clipboard
verified publisher icon spring-cloud

Github Auth method support

Open jgoldverg opened this issue 1 year ago • 1 comments

Is your feature request related to a problem? Please describe. Currently Vault supports Github Personal AccessTokens as an Auth method is there any plans to include this auth method into spring cloud vault and spring cloud vault config?

For a trivial solution I would expect I would expect that the property spring.cloud.vault.authentication would allow the field GITHUB where the spring.cloud.vault.token would contain the PAT. From the Vault documentation it seems like there is a separate API call for the Github Auth method which should make it fairly simple to include in a future version.

jgoldverg avatar Jun 04 '24 14:06 jgoldverg

There's already a PR at https://github.com/spring-projects/spring-vault/pull/853 so we will merge that one to create pre-requisites.

mp911de avatar Jun 06 '24 07:06 mp911de