spring-cloud-static icon indicating copy to clipboard operation
spring-cloud-static copied to clipboard
verified publisher icon spring-cloud

current symlink does not work for documentation anchor

Open snicoll opened this issue 6 years ago • 7 comments

Right now the current symlink only works if you're looking at the root page of the documentation, i.e. this URL http://cloud.spring.io/spring-cloud-static/current/ at the moment redirects to https://cloud.spring.io/spring-cloud-static/Greenwich.SR1.

However, the following examples lead to a 404:

  • https://cloud.spring.io/spring-cloud-static/Greenwich.SR1/current/spring-cloud.html
  • https://cloud.spring.io/spring-cloud-static/Greenwich.SR1/multi/multi__spring_cloud_context_application_context_services.html#_the_bootstrap_application_context

The redirection is also annoying as if you're going on current and then navigate to a particular aspect of the doc, you might copy a URL that's against a fixed version without noticing.

snicoll avatar Jun 18 '19 11:06 snicoll

@snicoll do you mean https://cloud.spring.io/spring-cloud-static/current/spring-cloud.html https://cloud.spring.io/spring-cloud-static/current/multi/multi__spring_cloud_context_application_context_services.html#_the_bootstrap_application_context?

I don't understand why you would expect Greenwich.SR1/current to work and your second URL works fine for me.

ryanjbaxter avatar Jun 18 '19 14:06 ryanjbaxter

you might copy a URL that's against a fixed version without noticing.

Ah ah, auto-owned. I copy/pasted the wrong links. I meant:

  • https://cloud.spring.io/spring-cloud-static/current/spring-cloud.html
  • https://cloud.spring.io/spring-cloud-static/current/multi/multi__spring_cloud_context_application_context_services.html#_the_bootstrap_application_context

(Whatever the version link is basically).

snicoll avatar Jun 18 '19 14:06 snicoll

See https://github.com/spring-cloud/spring-cloud-release-tools/issues/165

ryanjbaxter avatar Nov 18 '19 15:11 ryanjbaxter

@ryanjbaxter does that related issue address what's described here? I read it as a redirection to index.html but I am not sure it's going to handle any page/anchor.

snicoll avatar Nov 18 '19 15:11 snicoll

@snicoll according to @marcingrzejszczak it does. @marcingrzejszczak can you explain?

ryanjbaxter avatar Nov 19 '19 21:11 ryanjbaxter

No it won't handle anchors. It handles a redirect only. To handle anchors we would need to do some serious url rewriting.

marcingrzejszczak avatar Nov 20 '19 09:11 marcingrzejszczak

I had a chat with @snicoll and we agreed that symlinks will work fine from the hoxton release. So I'll update the releaset to make a symlink and the next release will be hoxton

marcingrzejszczak avatar Nov 20 '19 09:11 marcingrzejszczak