spring-cloud-openfeign icon indicating copy to clipboard operation
spring-cloud-openfeign copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Release RequestAttributes when called asynchronously. Fixes gh-716

Open vicasong opened this issue 2 years ago • 2 comments

vicasong avatar Sep 05 '22 15:09 vicasong

@vicasong Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Sep 05 '22 15:09 pivotal-cla

@vicasong Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Sep 05 '22 15:09 pivotal-cla

Fixes gh-716.

OlgaMaciaszek avatar Oct 17 '22 16:10 OlgaMaciaszek

I will resubmit a new PR

vicasong avatar Oct 19 '22 02:10 vicasong

Hello @vicasong, thanks a lot for submitting this PR. Sorry for not getting back to you earlier. Please add a test. Please add your full name with @author tag to the class javadoc. Also, could you please submit this PR against 3.1.x branch instead of main, so that we also get it included in the 2021.0.x release train?

PR #775 created.

vicasong avatar Oct 19 '22 02:10 vicasong