Resilience4j's TimeLimiter triggered after feign response

[DevDengChao]

Describe the bug Like the title said. I found that Resilience4j's TimeLimiter always triggered even feign client received response when feign method's return type is not void.

I'm using: OpenJDK 1.8.0_292-b10 and 11.0.11.9-hotspot Spring boot 2.5.2 Spring cloud 2020.0.3

Sample Here: https://github.com/DevDengChao/resilience4j-time-limiter-triggered-after-feign-response

[DevDengChao]

Any progress =-=?

[DevDengChao]

Downloading the source code ... Trying to figure out what goes wrong ... Maybe a PR later ...

[DevDengChao]

Maybe I should submit this at https://github.com/spring-cloud/spring-cloud-circuitbreaker 😆

--- UPDATED 2020-01-20 ---

Submitted as https://github.com/spring-cloud/spring-cloud-circuitbreaker/issues/120

[cbezmen]

Hi @DevDengCha, If you share example minimal repo which describes your bug, I will try to help you.

[DevDengChao]

Hi @DevDengCha, If you share example minimal repo which describes your bug, I will try to help you.

Here: https://github.com/DevDengChao/resilience4j-time-limiter-triggered-after-feign-response , just download it and run the application and you'll reproduce this bug.

[idd-esousa]

Any updates? Has the bug been resolved?

[DevDengChao]

@chenzhongya 你可以用 ``` 包裹 yaml 内容, 渲染后的格式会更容易阅读一些.

eg, input:

```yaml
feign:
  circuitbreaker:
    enabled: true
```

output:

feign:
  circuitbreaker:
    enabled: true

[DevDengChao]

New progress, see https://github.com/spring-cloud/spring-cloud-circuitbreaker/issues/120#issuecomment-1219968266

[OlgaMaciaszek]

Thanks @DevDengChao; I understand this workaround is working for you?

[DevDengChao]

@OlgaMaciaszek Yes, it works, and I updated the example repository, you can try it to confirm that.

[DevDengChao]

Should we close this issue now ?

[OlgaMaciaszek]

Yes, since the issue since to be addressed in the CB repo, I think we can close it here. Thank you for reporting it.