spring-cloud-netflix icon indicating copy to clipboard operation
spring-cloud-netflix copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Implement probe() in EurekaReactiveDiscoveryClient

Open OlgaMaciaszek opened this issue 2 years ago • 3 comments

See https://github.com/spring-cloud/spring-cloud-commons/issues/1105

OlgaMaciaszek avatar Jan 24 '23 12:01 OlgaMaciaszek

Can I work on this?

MarianConstantinMarica avatar Mar 19 '23 10:03 MarianConstantinMarica

Sure :).

OlgaMaciaszek avatar Mar 20 '23 08:03 OlgaMaciaszek

I'm commenting because I think the issue needs an update. 😄

  1. Are there still plans to implement the probe() in EurekaReactiveDiscoveryClient?

It seems to have changed to reactiveProbe due to https://github.com/spring-cloud/spring-cloud-commons/pull/1201.

  1. Are there no plans to implement it in DiscoveryClient as well?

I noticed that the probe() is also defined in DiscoveryClient.

See https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-commons/src/main/java/org/springframework/cloud/client/discovery/DiscoveryClient.java#L66..L68

heowc avatar May 04 '24 05:05 heowc