spring-cloud-netflix icon indicating copy to clipboard operation
spring-cloud-netflix copied to clipboard

Add Default Client TimeOut.

Open wzwllu opened this issue 3 years ago • 4 comments

Add connectRequestTimeout,connectTimeout,readTimeout。

wzwllu avatar Aug 08 '22 16:08 wzwllu

Why the tests failed on CircleCI? Only add the timeOut Config.

wzwllu avatar Aug 08 '22 16:08 wzwllu

If remove codes , CL is error too; It's 7d696c9.... please check the CL test.

wzwllu avatar Aug 08 '22 17:08 wzwllu

Hello, @wzwllu Thanks for submitting the PR. The tests will fail on main currently due to necessary changes waiting for merge in Netflix/Eureka. Please submit your PR against the 3.1.x branch instead of main.

OlgaMaciaszek avatar Aug 31 '22 09:08 OlgaMaciaszek

Fixes gh-4110.

OlgaMaciaszek avatar Sep 01 '22 11:09 OlgaMaciaszek

I wrote a new PR that satisfies the conditions. Ref

kworkbee avatar Dec 09 '22 08:12 kworkbee

Closing in favour of https://github.com/spring-cloud/spring-cloud-netflix/pull/4148.

OlgaMaciaszek avatar Dec 12 '22 11:12 OlgaMaciaszek