spring-cloud-netflix icon indicating copy to clipboard operation
spring-cloud-netflix copied to clipboard

DO NOT MERGE: Avoid cycle in getScheme().

Open OlgaMaciaszek opened this issue 3 years ago • 1 comments

Changes necessary after merging: https://github.com/spring-cloud/spring-cloud-commons/pull/937. Only merge after the commons PR is merged.

OlgaMaciaszek avatar Mar 31 '21 11:03 OlgaMaciaszek

Codecov Report

Merging #3983 (993f4ee) into master (9804818) will increase coverage by 0.03%. The diff coverage is 66.66%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3983      +/-   ##
============================================
+ Coverage     55.11%   55.15%   +0.03%     
- Complexity      507      508       +1     
============================================
  Files            57       57              
  Lines          2464     2466       +2     
  Branches        228      228              
============================================
+ Hits           1358     1360       +2     
+ Misses         1019     1018       -1     
- Partials         87       88       +1     
Impacted Files Coverage Δ Complexity Δ
...rk/cloud/netflix/eureka/EurekaServiceInstance.java 48.00% <66.66%> (+0.17%) 8.00 <1.00> (ø)
.../netflix/eureka/server/EurekaServerConfigBean.java 22.73% <0.00%> (+0.23%) 32.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9804818...993f4ee. Read the comment docs.

codecov[bot] avatar Mar 31 '21 11:03 codecov[bot]