spring-cloud-netflix icon indicating copy to clipboard operation
spring-cloud-netflix copied to clipboard

Update RoutesEndpoint.java

Open ZengYueWei opened this issue 5 years ago • 7 comments

CompositeRouteLocator will sort the routeLocator by their order , so that the higher priority routeLocator will be check first.

But when we checked the route infos (by getting /actuator/routes),the route infos are different from the result we request.

It turns out that the route infos are returned by map. Because of that, if they are same route infos offering by different routeLocator, the lower priority will rewrite the higher one route info. But when we send the request, the higher one will perform.

So, I think it's something we can change to reduce ambiguity by returing same route infos as we request.

ZengYueWei avatar Jun 28 '19 02:06 ZengYueWei

@ZengYueWei Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar Jun 28 '19 02:06 pivotal-issuemaster

@ZengYueWei Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar Jun 28 '19 02:06 pivotal-issuemaster

Codecov Report

Merging #3580 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3580      +/-   ##
============================================
- Coverage        65%   64.94%   -0.06%     
+ Complexity     1505     1503       -2     
============================================
  Files           190      190              
  Lines          7272     7272              
  Branches        870      870              
============================================
- Hits           4727     4723       -4     
- Misses         2232     2235       +3     
- Partials        313      314       +1
Impacted Files Coverage Δ Complexity Δ
...ngframework/cloud/netflix/zuul/RoutesEndpoint.java 74.54% <100%> (ø) 8 <0> (ø) :arrow_down:
...netflix/ribbon/ZonePreferenceServerListFilter.java 60.71% <0%> (-7.15%) 9% <0%> (-1%)
...oud/netflix/zuul/filters/post/SendErrorFilter.java 74.57% <0%> (-3.39%) 16% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c24e7e0...62a1bb9. Read the comment docs.

codecov[bot] avatar Jun 28 '19 02:06 codecov[bot]

Codecov Report

Merging #3580 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3580      +/-   ##
============================================
- Coverage        65%   64.94%   -0.06%     
+ Complexity     1505     1503       -2     
============================================
  Files           190      190              
  Lines          7272     7272              
  Branches        870      870              
============================================
- Hits           4727     4723       -4     
- Misses         2232     2235       +3     
- Partials        313      314       +1
Impacted Files Coverage Δ Complexity Δ
...ngframework/cloud/netflix/zuul/RoutesEndpoint.java 74.54% <100%> (ø) 8 <0> (ø) :arrow_down:
...netflix/ribbon/ZonePreferenceServerListFilter.java 60.71% <0%> (-7.15%) 9% <0%> (-1%)
...oud/netflix/zuul/filters/post/SendErrorFilter.java 74.57% <0%> (-3.39%) 16% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c24e7e0...62a1bb9. Read the comment docs.

codecov[bot] avatar Jun 28 '19 02:06 codecov[bot]

Codecov Report

Merging #3580 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3580      +/-   ##
============================================
- Coverage        65%   64.94%   -0.06%     
+ Complexity     1505     1503       -2     
============================================
  Files           190      190              
  Lines          7272     7272              
  Branches        870      870              
============================================
- Hits           4727     4723       -4     
- Misses         2232     2235       +3     
- Partials        313      314       +1
Impacted Files Coverage Δ Complexity Δ
...ngframework/cloud/netflix/zuul/RoutesEndpoint.java 74.54% <100%> (ø) 8 <0> (ø) :arrow_down:
...netflix/ribbon/ZonePreferenceServerListFilter.java 60.71% <0%> (-7.15%) 9% <0%> (-1%)
...oud/netflix/zuul/filters/post/SendErrorFilter.java 74.57% <0%> (-3.39%) 16% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c24e7e0...62a1bb9. Read the comment docs.

codecov[bot] avatar Jun 28 '19 02:06 codecov[bot]

Codecov Report

Merging #3580 into master will decrease coverage by 0.05%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #3580      +/-   ##
============================================
- Coverage        65%   64.94%   -0.06%     
+ Complexity     1505     1503       -2     
============================================
  Files           190      190              
  Lines          7272     7272              
  Branches        870      870              
============================================
- Hits           4727     4723       -4     
- Misses         2232     2235       +3     
- Partials        313      314       +1
Impacted Files Coverage Δ Complexity Δ
...ngframework/cloud/netflix/zuul/RoutesEndpoint.java 74.54% <100%> (ø) 8 <0> (ø) :arrow_down:
...netflix/ribbon/ZonePreferenceServerListFilter.java 60.71% <0%> (-7.15%) 9% <0%> (-1%)
...oud/netflix/zuul/filters/post/SendErrorFilter.java 74.57% <0%> (-3.39%) 16% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c24e7e0...62a1bb9. Read the comment docs.

codecov[bot] avatar Jun 28 '19 02:06 codecov[bot]

Can you include a test?

spencergibb avatar Sep 16 '19 16:09 spencergibb