spring-cloud-netflix icon indicating copy to clipboard operation
spring-cloud-netflix copied to clipboard

Enable request buffering when request body tracing

Open candrews opened this issue 6 years ago • 4 comments

Request body tracing reads the body then it will be read again later for actual handling. Therefore, request buffering is required when request body tracing.

Fixes https://github.com/spring-cloud/spring-cloud-netflix/issues/3418

candrews avatar Mar 19 '19 15:03 candrews

Codecov Report

Merging #3440 into 2.0.x will decrease coverage by 0.51%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.0.x    #3440      +/-   ##
============================================
- Coverage     66.65%   66.14%   -0.52%     
+ Complexity     1484     1482       -2     
============================================
  Files           183      183              
  Lines          6922     6924       +2     
  Branches        845      846       +1     
============================================
- Hits           4614     4580      -34     
- Misses         1994     2028      +34     
- Partials        314      316       +2
Impacted Files Coverage Δ Complexity Δ
...tflix/zuul/filters/pre/Servlet30WrapperFilter.java 75% <50%> (-2.78%) 6 <0> (ø)
...cloud/netflix/eureka/EurekaInstanceConfigBean.java 52.28% <0%> (-16.76%) 53% <0%> (-1%)
...etflix/turbine/stream/HystrixStreamAggregator.java 73.68% <0%> (-5.27%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21e7cca...d98a0e5. Read the comment docs.

codecov[bot] avatar Mar 19 '19 15:03 codecov[bot]

Codecov Report

Merging #3440 into 2.0.x will decrease coverage by 0.51%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.0.x    #3440      +/-   ##
============================================
- Coverage     66.65%   66.14%   -0.52%     
+ Complexity     1484     1482       -2     
============================================
  Files           183      183              
  Lines          6922     6924       +2     
  Branches        845      846       +1     
============================================
- Hits           4614     4580      -34     
- Misses         1994     2028      +34     
- Partials        314      316       +2
Impacted Files Coverage Δ Complexity Δ
...tflix/zuul/filters/pre/Servlet30WrapperFilter.java 75% <50%> (-2.78%) 6 <0> (ø)
...cloud/netflix/eureka/EurekaInstanceConfigBean.java 52.28% <0%> (-16.76%) 53% <0%> (-1%)
...etflix/turbine/stream/HystrixStreamAggregator.java 73.68% <0%> (-5.27%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21e7cca...d98a0e5. Read the comment docs.

codecov[bot] avatar Mar 19 '19 15:03 codecov[bot]

Codecov Report

Merging #3440 into 2.0.x will decrease coverage by 0.51%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.0.x    #3440      +/-   ##
============================================
- Coverage     66.65%   66.14%   -0.52%     
+ Complexity     1484     1482       -2     
============================================
  Files           183      183              
  Lines          6922     6924       +2     
  Branches        845      846       +1     
============================================
- Hits           4614     4580      -34     
- Misses         1994     2028      +34     
- Partials        314      316       +2
Impacted Files Coverage Δ Complexity Δ
...tflix/zuul/filters/pre/Servlet30WrapperFilter.java 75% <50%> (-2.78%) 6 <0> (ø)
...cloud/netflix/eureka/EurekaInstanceConfigBean.java 52.28% <0%> (-16.76%) 53% <0%> (-1%)
...etflix/turbine/stream/HystrixStreamAggregator.java 73.68% <0%> (-5.27%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21e7cca...d98a0e5. Read the comment docs.

codecov[bot] avatar Mar 19 '19 15:03 codecov[bot]

Codecov Report

Merging #3440 into 2.0.x will decrease coverage by 0.51%. The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##              2.0.x    #3440      +/-   ##
============================================
- Coverage     66.65%   66.14%   -0.52%     
+ Complexity     1484     1482       -2     
============================================
  Files           183      183              
  Lines          6922     6924       +2     
  Branches        845      846       +1     
============================================
- Hits           4614     4580      -34     
- Misses         1994     2028      +34     
- Partials        314      316       +2
Impacted Files Coverage Δ Complexity Δ
...tflix/zuul/filters/pre/Servlet30WrapperFilter.java 75% <50%> (-2.78%) 6 <0> (ø)
...cloud/netflix/eureka/EurekaInstanceConfigBean.java 52.28% <0%> (-16.76%) 53% <0%> (-1%)
...etflix/turbine/stream/HystrixStreamAggregator.java 73.68% <0%> (-5.27%) 8% <0%> (-1%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21e7cca...d98a0e5. Read the comment docs.

codecov[bot] avatar Mar 19 '19 15:03 codecov[bot]