spring-cloud-kubernetes icon indicating copy to clipboard operation
spring-cloud-kubernetes copied to clipboard

Fix circleci flow

Open wind57 opened this issue 3 years ago • 1 comments

wind57 avatar Aug 09 '22 18:08 wind57

When ActuatorRefreshKafkaIT started failing in github workflow, I could not understand why does it passes in circleci? It meant two things:

  • circleci was caching SNAPSHOT dependencies, and we were never properly using snapshots. This was indeed the case, and while looking more closely and debugging a bit, I found out that the cache we were using was never being updated with latest snapshots. I fixed that in this PR.
  • and second, it meant that ActuatorRefreshKafkaIT was broken because of a recent snapshot version of some library: the test was passing in circleci (where we had an older snapshot version and we were never using the newest one), and was failing in github workflow - where we were using the most recent snapshot version.

This PR also cleans up a bit the pipeline making it more readable. In essence, the flow/logic stays the same; but it's more readable now, imho.

And of course now, because we fixed this issue, ActuatorRefreshKafkaIT fails - which is normal and expected. When we figure out what is going on and fix the underlying problem, a rebuild here will pass the test.


This PR can go in, only after the github actions one does.

wind57 avatar Aug 10 '22 14:08 wind57

@ryanjbaxter this is the next one in the list for you to review when you get a chance. thank you

wind57 avatar Aug 17 '22 15:08 wind57