spring-cloud-gateway icon indicating copy to clipboard operation
spring-cloud-gateway copied to clipboard
verified publisher icon spring-cloud

fix: add splitting of comma separated cache-control values

Open danielshiplett opened this issue 1 year ago • 5 comments

This PR is to address https://github.com/spring-cloud/spring-cloud-gateway/issues/3431

danielshiplett avatar Jun 14 '24 19:06 danielshiplett

@danielshiplett Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Jun 14 '24 19:06 pivotal-cla

Please sign the cla

spencergibb avatar Nov 20 '24 17:11 spencergibb

@danielshiplett Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Nov 20 '24 17:11 pivotal-cla

This breaks numerous tests in LocalResponseCacheGatewayFilterFactoryTests. Can you take a look?

spencergibb avatar Nov 20 '24 18:11 spencergibb

Looks like this would cause some test failures. Also the DCO needs to addressed

ryanjbaxter avatar May 13 '25 20:05 ryanjbaxter