spring-cloud-gateway icon indicating copy to clipboard operation
spring-cloud-gateway copied to clipboard

Allow stripPrefix to be less strict about contextPaths

Open hildo opened this issue 1 year ago • 2 comments

@spencergibb I was thinking about the issue #1935 .. would something like this be appropriate?

This is not complete, and tests would need to be added. But it would be convenient of users of StripPrefix (or additional filters) could dictate whether the strict validation should be enforced?

I know for the use case I am facing we don't need the context path enforced on the target service. But I am presuming that this was introduced for a reason. However, when I override this locally with a different filter (which is the same as StripPrefix but with the change in the PR hard coded), everything seems to work fine.

If you think there is merit here, I am happy to continue getting the tests to pass and adding in new tests. I just wanted to confirm with you whether this was a plausible solution. If so, I will try to get this into a mergeable state (in case I haven't been clear, this Pull Request is not in a mergeable state).

Thanks

hildo avatar Jul 23 '23 06:07 hildo

@hildo Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-cla avatar Jul 23 '23 06:07 pivotal-cla

@hildo Thank you for signing the Contributor License Agreement!

pivotal-cla avatar Jul 23 '23 07:07 pivotal-cla