spring-cloud-deployer icon indicating copy to clipboard operation
spring-cloud-deployer copied to clipboard

Support S3 repositories

Open YoannBuch opened this issue 8 years ago • 2 comments

Artifacts may be stored in AWS S3 buckets (using https://github.com/spring-projects/aws-maven).

MavenArtifactResolver could support that scenario if the following changes are made:

spring-cloud-deployer-resource-maven/pom.xml

<dependency>
    <groupId>org.springframework.build</groupId>
    <artifactId>aws-maven</artifactId>
    <version>5.0.0.RELEASE</version>
</dependency>
<dependency>
    <groupId>org.eclipse.aether</groupId>
    <artifactId>aether-transport-wagon</artifactId>
    <version>${aether.version}</version>
</dependency>

MavenArtifactResolver.java

In newRepositorySystem()

locator.addService(TransporterFactory.class, WagonTransporterFactory.class);
locator.setServices(WagonProvider.class, new WagonProvider() {

    @Override
    public Wagon lookup(String roleHint) throws Exception {

        if ("s3".equals(roleHint)) {
            return new SimpleStorageServiceWagon();
        }

        return null;
    }

    @Override
    public void release(Wagon wagon) {

    }
});

Let me know what you think and if you would like a PR instead.

YoannBuch avatar Jun 30 '16 19:06 YoannBuch

Hello, @YoannBuch, I would really like to see that feature in this project, it's a pity that 2,5 year later there are no reactions :(

adamMo avatar Dec 29 '18 22:12 adamMo

Changing the title of this issue to support an S3 artifact repository, not necessarily integrated with Maven. The approach described in the OP is a dead end since the code and it's various forks are no longer supported for

<dependency>
    <groupId>org.springframework.build</groupId>
    <artifactId>aws-maven</artifactId>
    <version>5.0.0.RELEASE</version>
</dependency>

We will consider alternate ways to support S3 artifacts

dturanski avatar Jul 31 '19 16:07 dturanski