spring-cloud-deployer-cloudfoundry icon indicating copy to clipboard operation
spring-cloud-deployer-cloudfoundry copied to clipboard

Should task launch delete the application after successful launch

Open ilayaperumalg opened this issue 6 years ago • 2 comments

In the current scenario, when the task is launched the task application still remains in stopped state and restarted for the subsequent launch.

While this gives benefit in starting up time for the subsequent launch, in cases where the start parameters like JAVA_OPTS need to be changed in the task launch then, it wouldn't work as the launch reuses the existing application.

ilayaperumalg avatar Apr 11 '18 09:04 ilayaperumalg

I observed the same. The deployer sets up a Cloud Foundry app and binds services specified in deployment properties to it however after the runtime completes the apps are stopped but never cleaned up from the CF account. We have a use case to execute tasks in big numbers all at once (~100 concurrent instances) to process a dataset of 0.5 Million data-points and with current behaviour it looks like we will end up having 0.5 Million CF apps with each bound to a few services. Is this really how it supposed to work by design?

BartoszKaszewczuk avatar Apr 16 '18 08:04 BartoszKaszewczuk

I suspect the behavior is still the same in 2023, though there are limits to how many tasks can be deployed, so I don't understand the logic behind the comment of 0.5 million CF apps being deployed to process 0.5 Million data points.

No one has brought this up in 5 years, so it must be a rare use-case to change JAVA_OPS on a subsequent launch.

Needs some discussion

markpollack avatar Apr 18 '23 13:04 markpollack