spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Version updates and cleanup on Skipper files.

Open corneil opened this issue 1 year ago • 1 comments
trafficstars

corneil avatar Apr 29 '24 12:04 corneil

Looks like we picked up a build failure.

cppwfs avatar Apr 29 '24 13:04 cppwfs

I restarted the tests for this PR and one of the changes is causing the skipper tests to fail. This is not occurring in the main-3 branch.

cppwfs avatar Apr 29 '24 21:04 cppwfs

LGTM ! Thanks @corneil !

Here are the why's:

  • Switch to jlumbroso/free-disk-space Some tests failed because we were running out of disk space on the server

  • This prevented the build from starting because we do not push docker changes. remove docker

  • Soon we will be moving the JUnit 5 work in main to this branch Skip tests on spring-cloud-skipper-core Removed JMockit.

cppwfs avatar Apr 30 '24 13:04 cppwfs

OOps forgot to click close :-)

Repeat of previous comment: LGTM ! Thanks @corneil !

Here are the why's:

What: Switch to jlumbroso/free-disk-space Why: Some tests failed because we were running out of disk space on the server

What:remove docker & Skip tests on spring-cloud-skipper-core & Removed JMockit. Why:This prevented the build from starting because we do not push docker changes.

cppwfs avatar Apr 30 '24 13:04 cppwfs