spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

DataflowSqlPagingQueryProvider

Open corneil opened this issue 1 year ago • 3 comments
trafficstars

Implement DataflowSqlPagingQueryProvider by copying implementations from Spring Batch 4.x org.springframework.batch.item.database.support Removed @Disabled for tests that now function as expected.

corneil avatar Mar 28 '24 13:03 corneil

Also seeing failures on the following tests: LocalPlatformTests RESOLVED I had a port conflict on my machine. All is good for this issue.

cppwfs avatar Apr 04 '24 13:04 cppwfs

Rebased this PR locally and tried to build locally. I had to bump up the timeout for oracle to 6 minutes from the original 4 minutes. i.e. oracleContainer.withStartupTimeout(Duration.ofMinutes(6));.
Also I'm seeing where the CI fails when trying to pull ibmcom/db2:11.5.8.0. But when I remove the image locally, it can pull it. Maybe we have a setting hiccup in our docker pulls in our github actions.

cppwfs avatar Apr 26 '24 19:04 cppwfs

ContainerIntegrationTests

Is docker-compose installed? I noticed today that a default docker installation doesn't include the docker-compose application anymore. docker compose can be used instead. I believe we should update the DockerCompose support to check for the presence of docker-compose and if it isn't present assume the docker version can support docker compose

corneil avatar Apr 29 '24 11:04 corneil

I'm wondering if these commits can be in their own PR. What are your thoughts?

I made updated in a separate commit for now.

corneil avatar May 03 '24 13:05 corneil