spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

metrics property name of wavefront can not be matched

Open wczhang1986 opened this issue 1 year ago • 4 comments
trafficstars

Description: In the dashboard, when I view stream definition, I see additional properties getting added for metrics like management.wavefront.metrics.export.uri. but in wavefront for boot3,we set uri of wavefront by using management.wavefront.uri. I think it is the bug in MetricsReplicationEnvironmentPostProcessor.java:metricsPropertyNameInBoot3 the METRIC_PROP_NAME_PATTERN can not match management.wavefront.uri.

Release versions: 2.11.0

Steps to reproduce:

Screenshots: image

wczhang1986 avatar Feb 01 '24 09:02 wczhang1986

@wczhang1986 The processing by MetricsReplicationEnvironmentPostProcessor only translates from Boot 2.x to 3.x conventions

Boot 2.x: 'management.metrics.export.<meter-registry>.<property-path>'
Boot 3.x: 'management.<meter-registry>.metrics.export.<property-path>'

The metrics registry specific properties should be provided by the user.

If you add app.kafka.management.wavefront.uri it will be applied as expected.

corneil avatar Feb 02 '24 09:02 corneil

If you add app.kafka.management.wavefront.uri it will be applied as expected.

Thanks , But ,If I want to use stream application after version 4.0.0 with wavefront, I need to set this properties every application. It doesn't feel very good by this way. And first time we do this ,we did not know we need to set app.kafka.management.wavefront.uri by myself。

wczhang1986 avatar Feb 04 '24 09:02 wczhang1986

I have created #5689

corneil avatar Feb 21 '24 12:02 corneil

@wczhang1986 The management properties configured for Spring Cloud DataFlow Server and Skipper server are also used as defaults when launching applications.

corneil avatar Feb 22 '24 08:02 corneil

Closing due to inactivity. If closed in error please let us know.

cppwfs avatar Jul 22 '24 14:07 cppwfs