spring-cloud-dataflow
spring-cloud-dataflow copied to clipboard
Refactor the Dataflow dependency management hierarchy
There are currently multiple locations where versions are managed in the Dataflow monorepo.
- [ ] Produce a hierarchy diagram clearly showing the parent/child/import relationships of all modules in the monorepo
- [ ] Based on the above, consolidate the version management into a single location.
- [ ] As we refactor let's add TODO comment on custom version overrides in hopes that we remove it once it is properly managed by the upstream library (ie Spring Boot)
- [ ] From a 15minute glance, it seems that almost everything either inherits (ultimately) from either
spring-cloud-dataflow-parent
orspring-cloud-dataflow-build-dependencies
. The twist to the above is that all Skipper modules have parent =spring-cloud-skipper-parent
EXCEPT the special snowflakespring-cloud-skipper-server
which has parent =spring-cloud-dataflow-parent
. It would be ideal if all Skipper modules inherited the same parent.
Here is the commit that shows where the versions had to be overidden.
Hey @onobc does this belongs to https://github.com/spring-cloud/spring-cloud-dataflow/issues/5405 - or do you mean the hierarchies in general?
Hi @klopfdreh , this is more of a general review of the modules inter-dependencies from when we did the move to the monorepo. It needs a review and most likely a refactoring.
Thanks for the clarification. 👍