spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

Feature: Configurable timeout for child task startup in CTR

Open Clemens-L opened this issue 2 years ago • 2 comments
trafficstars

Allows the configuration of a timeout for the startup of child tasks (max-start-wait-time) in the Composed Task Runner that can be smaller than the timeout for task completion (max-wait-time).

To check whether a child task is still in startup, we check whether the start time of the taskExecution has been set:

(taskExecution == null || taskExecution.getStartTime() == null)

This has been very helpful in our application, where we have some very long running tasks. By setting a max-start-wait-time that is significantly smaller than the max-wait-time, we can react a lot faster to tasks that fail on startup (for example, due to application context initialization failures).

Clemens-L avatar Sep 29 '23 09:09 Clemens-L

HI @Clemens-L I just wanted to reach out to let you know that we see your contribution and will get to it asap after we get the 2.11.2 release out. Thanks for your patience.

onobc avatar Nov 10 '23 15:11 onobc

Sounds good, thanks! 👍

Clemens-L avatar Nov 11 '23 21:11 Clemens-L

The changes look good. Can you rebase and we'll merge!

cppwfs avatar Apr 23 '24 19:04 cppwfs

Hi @cppwfs, done! Thanks for getting back to this

Clemens-L avatar Apr 23 '24 19:04 Clemens-L

@Clemens-L Thank you soooooo much for this contribution. We apologize for not getting it in sooner. Keep up the great contributions!

I only had to add a small polish on merge so that the option would appear in the UI.

cppwfs avatar Apr 23 '24 20:04 cppwfs

LGTM Polish,Squashed, merged Thank you for the contribution!!!

cppwfs avatar Apr 23 '24 20:04 cppwfs