spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

feat: enable ctr annotation build custom configuration

Open klopfdreh opened this issue 2 years ago • 6 comments
trafficstars

Addresses: https://github.com/spring-cloud/spring-cloud-dataflow/issues/4597

klopfdreh avatar Jun 05 '23 05:06 klopfdreh

@cppwfs / @onobc - I hope this way you also can customize the bean creation otherwise the ComposedTaskRunnerConfiguration should be changed and allow to override of beans

klopfdreh avatar Jun 05 '23 05:06 klopfdreh

@klopfdreh we truly appreciate this improvement but it will have to wait until after 2.11.0 as it is big enough of a change to warrant extra care and we are all busy focusing on what is already in scope for 2.11.0. Marking it as on-hold and we will review post 2.11.0. Thank you.

onobc avatar Jun 05 '23 18:06 onobc

@onobc - I guess it would be easier to redo the work at the current main branch. Let me know if the work should be done and I am going to force push a new version.

klopfdreh avatar Nov 09 '23 22:11 klopfdreh

@onobc - as the 2.11.3 release is out - should I do a rework on this so that we can merge it? @Clemens-L already provided one of our customizations to the code base with: https://github.com/spring-cloud/spring-cloud-dataflow/commit/13486fcef74e1bdc1f6aeca659a1c76ee5269adf and it would be much easier when we dont have to copy all the classes for customization anymore 😄

klopfdreh avatar May 27 '24 06:05 klopfdreh

Hello @klopfdreh, Thanks for reaching out! Let's hold for a just a bit longer, we are about to start work on 3.x and you can migrate then. We'll be announcing this soon!

cppwfs avatar May 28 '24 12:05 cppwfs

Hello @klopfdreh, Thanks for reaching out! Let's hold for a just a bit longer, we are about to start work on 3.x and you can migrate then. We'll be announcing this soon!

All right! 👍

klopfdreh avatar May 28 '24 13:05 klopfdreh