spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

[task-relaunch] Don't load Platform or Deployment properties if not specified

Open sergiodelgadocastellanos opened this issue 3 years ago • 2 comments

Problem description:

We are seeing that since 2.3.0, if a task has been launched with certain Deployment and Platform properties, every execution that we launch of said task will carry the previous properties.

The problem is that, if we change the version of the application that the task launches, and we don't need the use of secretKeyRefs because we have deleted an access to a database and we don't need to access this information, the secretKeyRefs in SCDF will be kept even if we don't specify them, resulting in a wrong deployment, since the pod couldn't find them.

Solution description:

I'd be nice to have some kind of flag or property that doesn't load by default the previous deployment and platform properties.

@onobc @markpollack Is this already considered and implemented in SCDF?

This has come up several times, here is one example - https://github.com/spring-cloud/spring-cloud-dataflow/issues/4467 we should look into this option of 'resetting' the task definition. In the meantime, you can remove them by setting them to empty values.

deployer.<app-name>.kubernetes.volumeMounts=
deployer.<app-name>.kubernetes.volumes=

as in the issue 4467 linked to above. I'm putting this on the 2.10 backlog since we would like to address several outstanding task related issues as a sort of 'theme' for the 2.10 release.

markpollack avatar Aug 16 '22 15:08 markpollack