spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Composed Task Runner does not propagate properties to child tasks

Open klopfdreh opened this issue 2 years ago • 1 comments

Description: As described here: https://github.com/spring-cloud/spring-cloud-dataflow-ui/issues/1880. The composed task runner does not propagate child task properties correctly.

Example:

image

Composed task name: test with DSL zuwendungen-cleaner-komo-app && zuwendungen-transformer-komo-app Task 1: zuwendungen-cleaner-komo-app registered as task application Task 2: zuwendungen-transformer-komo-app registered as task application

Task application example screenshot: image

Spring Cloud Data Flow creates two tasks named test-zuwendungen-cleaner-komo-app and test-zuwendungen-transformer-komo-app beside the composed task test. (As you can see in the first screenshot)

When I use the following property:

deployer.zuwendungen-cleaner-komo-app.kubernetes.environmentVariables=myenvvar=test it is not given to the child task application zuwendungen-cleaner-komo-app. When I use deployer.test.zuwendungen-cleaner-komo-app.kubernetes.environmentVariables=myenvvar=test (with test. after deployer) it is working. To use test. in the properties is deprecated as of https://github.com/spring-cloud/spring-cloud-dataflow/pull/5005 and https://github.com/spring-cloud/spring-cloud-dataflow-ui/issues/1880#issuecomment-1187587439

Release versions: We use the newest Spring Cloud Data Flow Server Version 2.9.4 with the Composed Task Runner 2.9.4 and Spring Cloud Skipper 2.8.4.

Custom apps: The task application does not matter in this case, because it fails to start anyway because of missing properties / environment variables which are not propagate of the CTR correctly.

Steps to reproduce: As described:

  1. Create two task applications and create a composed task with a simple mytaskapp1 && mytaskapp2-DSL.
  2. Start the composed task with deployer.mytaskapp1.kubernetes.environmentVariables=myenvvar=test
  3. See that this property is not given to the child task application.

Screenshots: See description.

Additional context: None

klopfdreh avatar Aug 09 '22 06:08 klopfdreh

Follow up of issue: https://github.com/spring-cloud/spring-cloud-dataflow-ui/issues/1880

klopfdreh avatar Aug 09 '22 06:08 klopfdreh

Closed because of https://github.com/spring-cloud/spring-cloud-dataflow/issues/5070

klopfdreh avatar Aug 30 '22 19:08 klopfdreh