spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

Add Back support for mysql 5.7 with the commercial flyway library

Open markpollack opened this issue 3 years ago • 4 comments

TBD

markpollack avatar Apr 07 '22 14:04 markpollack

I was able to get 2.9.x SCDF running against MySQL 5.7 using the Flyway Teams edition.

Here is what I did:

Current (base case lets prove its broken)

  • Start MySQL 5.7
  • Start SCDF 2.9.x w/ MariaDB driver pointing to MySQL 5.7
  • BIG 💥 💥 EXPLOSION - no 🎲 !!

With Flyway Teams

  • Obtain a Flyway Teams trial license
  • Change Flyway dependency in spring-cloud-dataflow-common-flyway
  • Set Flyway license in env var
  • Start MySQL 5.7
  • Start SCDF 2.9.x w/ MariaDB driver pointing to MySQL 5.7
  • NO explosions - just 💰 profit!!!

Next Steps

Make this work in PRO only. Will do this next week.

onobc avatar Apr 22 '22 18:04 onobc

ℹ️ SB 2.5.12 runs w/ Flyway 7.7.3 but the trial license only works w/ 8.x so I used the 8.0.5 Flyway version. I am sure we could get l license for the 7.7.3 version if need be.

I will figure out which version we are currently using in 2.9.x.

SB version Flyway version
2.5.12 7.7.3
2.6.6 8.0.5
2.7.0-RC1 8.5.9

onobc avatar Apr 22 '22 18:04 onobc

I have this working for MySQL 5.7 + SB 2.6.6 + Flyway Teams. I will get it ready in a PR.

onobc avatar Apr 27 '22 03:04 onobc

[Implementation Note]: We may be able to always use the Flyway teams lib and set the "edition" property to community in the non-pro case. This would allow us to not worry about using different libs in PRO/OSS. This would be good because we do not have a Pro Skipper and therefore would have to deploy 2 skipper libs (w/ and w/o teams lib).

The hope is the "Warning" message about teams goes away when using the "edition=community" setting.

onobc avatar May 12 '22 18:05 onobc

Closed via https://github.com/spring-cloud/spring-cloud-dataflow/commit/8ab2b1e97f7cf6cba7cfb3313caf037bb127f908

onobc avatar Sep 07 '22 03:09 onobc