spring-cloud-dataflow icon indicating copy to clipboard operation
spring-cloud-dataflow copied to clipboard

[Do Not Merge] Validate the registered apps existence

Open tzolov opened this issue 4 years ago • 1 comments

  • Add isMetadataResourceExists(Resource app) method to the App configuration metadata resolver APIs - later verifies that the metadata artifact being a metadata jar, application jar or docker image exists physically.

  • Extend the AppRegistryController #register and #registerAll methods with an optional, artefact-validation boolean flag. For backward compatibility the artefact-validation defaults to false.

  • The AppRegistryController#register() method with artefact-validation=true will fail with NonExistingApplicationArtefactException if the URIs are pointing to non-existing artefacts. The application registration is aborted.

  • The new NonExistingApplicationArtefactException exception is added to the RestControllerAdvice

  • The AppRegistryController#register() method with artefact-validation=true will store all valid registration but will remove those that faile to resovle their metadata URIs. The error message lists the failing app's URIs.

  • REST client's AppRegistryOperations#{register,registerimportFromResource,registerAll} methods are extended with an optional artefactValidation parameter.

  • Add some initial tests.

Resolves #1497

tzolov avatar Sep 15 '21 17:09 tzolov

let's speak to christian and see if this is still relevant.

markpollack avatar Aug 11 '22 14:08 markpollack

I am closing this one, it has been in the same limbo for quite some time.

onobc avatar Nov 14 '22 16:11 onobc