spring-cloud-dataflow-ui icon indicating copy to clipboard operation
spring-cloud-dataflow-ui copied to clipboard

Add custom prefix/suffix when bulk importing OOTP apps

Open sabbyanandan opened this issue 3 years ago • 3 comments

As a user, I'd like to import both RMQ and Kafka apps; while the imports work, but the registration corrupts the pallette when it loads because of the duplicate names/nodes.

See below: image

Possible solutions:

  • Either we don't allow bulk import of both RMQ and Kafka
  • Add an option when importing to prefix/suffix with something extra to the app names
  • Highlight the apps with its unique name to avoid conflicts

sabbyanandan avatar Jun 03 '21 18:06 sabbyanandan

The REST endpoint for Bulk Import uses a URL as parameter. The URL points to a file that contains a list of apps. We can not, on the UI side, transform the apps list (add a prefix/suffix).

oodamien avatar Jun 07 '21 11:06 oodamien

You really can't even register rabbit/kafka apps with same name as it throws

java.lang.IllegalArgumentException:
Existing default application [maven://org.springframework.cloud.stream.app:file-sink-rabbit:3.0.1]
can only differ by a version but is [maven://org.springframework.cloud.stream.app:file-sink-kafka:3.0.1]

Bulk import silently drops apps which doesn't import.

jvalkeal avatar Jun 09 '21 16:06 jvalkeal

@oodamien that "duplicate element" is logged here https://github.com/spring-cloud/spring-cloud-dataflow-ui/blob/c507a20737ba9d32809386776c17ac2c3111a86a/ui/src/app/flo/stream/metamodel.service.ts#L91 if you have sink/source with same name.

jvalkeal avatar Jun 09 '21 17:06 jvalkeal