spring-cloud-dataflow-ui icon indicating copy to clipboard operation
spring-cloud-dataflow-ui copied to clipboard

Certain Characters within Properties Cause Task Definitions Not To Render

Open SofaRabbit opened this issue 5 years ago • 1 comments

There are certain seemingly special characters that, when specified as part of properties within a given task, will cause the task definition to be inaccessible and not viewable in the UI.

Steps to Reproduce:

  1. Select the Tasks tab.
  2. Click the Create Task(s) button.
  3. Drag a task from beneath the task section onto the canvas and configure the properties. Be sure to attach it to the START and END blocks. Screen Shot 2019-11-27 at 12 39 30 PM
  4. This particular bug is most obvious when specifying regex expressions as part of properties. Configure the task with a property value which uses a regex expression such as \S_table* which could be used to act on all tables which end with _table. It is important to note that at this point, the interface will allow the specification of a regex expression. Screen Shot 2019-11-27 at 12 41 05 PM
  5. Click the Create Task button and finish creating the task.
  6. Return to the Tasks page and search to find your created task. Screen Shot 2019-11-27 at 12 44 22 PM
  7. Click on the hyperlinked name of the task to drill into the details on the task. Notice that the definition never loads. This is particularly detrimental in cases where we have composed tasks because this will prevent the entire composed task definition from being loaded. Screen Shot 2019-11-27 at 12 45 44 PM

SofaRabbit avatar Nov 27 '19 17:11 SofaRabbit

Hi, @SofaRabbit. My apologies for the delayed response. This is indeed a problem, but there's a workaround that you can by escaping the backslash. For example, when creating the definition using the DSL or the Dialog window, you can plug the value as \\S*_table — essentially escaping the backslash in the value. This should unblock you from going. Let us know what you think.

We will still review it on our side to how we can automate the escaping in the UI, so I will keep this open.

sabbyanandan avatar Feb 26 '20 19:02 sabbyanandan