spring-cloud-contract icon indicating copy to clipboard operation
spring-cloud-contract copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

jpms

Open xenoterracide opened this issue 9 months ago • 5 comments

please add jpms support, at least automatic modules for now. However, this issue or another issue should be added for full module-info at sometime in the future. Referencing this upstream spring issue (specifically comment) which shows all of the dependencies that could be included via the code generator https://github.com/spring-projects/spring-framework/issues/18079#issuecomment-2087396680

xenoterracide avatar May 09 '24 15:05 xenoterracide

We will follow the lead of spring-framework regarding this.

spencergibb avatar May 09 '24 16:05 spencergibb

Currently spring framework is using automatic modules. I flagged this because it doesn't appear to have any automatic module. At least not according to that report.

To catch up you should add an automatic module today so that people who want to use JPMS can compile against spring-cloud-contract. I'm not really expecting a full module-info at this time, that's the long term ideal though.

xenoterracide avatar May 09 '24 16:05 xenoterracide

Hey, any idea how to generate the automatic module in Maven?

marcingrzejszczak avatar Jun 27 '24 10:06 marcingrzejszczak

I do not. Although I'm not sure it's worth generating because I think it's only one line in the manifest.mf.

xenoterracide avatar Jun 27 '24 13:06 xenoterracide

Related PR

marcingrzejszczak avatar Jun 28 '24 09:06 marcingrzejszczak