spring-cloud-consul icon indicating copy to clipboard operation
spring-cloud-consul copied to clipboard

Make profile specific paths optional

Open DanielYWoo opened this issue 3 years ago • 2 comments

As stated in https://github.com/spring-cloud/spring-cloud-consul/issues/787 we need to mitigate the pressure to Consul, so the change is to add a new flag to get rid of profiles in a large deployment.

The change is simple, now we have a flag spring.cloud.consul.config.profileEnabled, and default to true to keep it compatible with the current behavior. When disabled, we will scan less paths on Consul.

P.S. Many of the changes are due to checkstyle, not really related to this change. I have to fix them to make the build pass.

DanielYWoo avatar Jun 10 '22 10:06 DanielYWoo

@ryanjbaxter If this is approved, how do I update the documents?

DanielYWoo avatar Jun 14 '22 10:06 DanielYWoo

I just approved the build to run I don't understand the checkstyle failures though

ryanjbaxter avatar Jun 14 '22 14:06 ryanjbaxter