spring-cloud-consul icon indicating copy to clipboard operation
spring-cloud-consul copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Adds failover data centers to DiscoveryClient. Fixes gh-712

Open d4c4nf3 opened this issue 4 years ago • 4 comments

Adds a new property in discovery client configuration, a list named failoverDataCenters. If discovery client cannot find instance of wanted service in local cluster it will look for instances of that service in given data centers.

See #712

d4c4nf3 avatar Nov 07 '20 21:11 d4c4nf3

@Vojislav-Cuk Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar Nov 07 '20 21:11 pivotal-issuemaster

@Vojislav-Cuk Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar Nov 09 '20 09:11 pivotal-issuemaster

IMO I think we should get all instances from all configured data centers, and then only fail over to other data centers in the case that the instances in the current data center are not responsive.

ryanjbaxter avatar Apr 12 '21 14:04 ryanjbaxter

My reasoning for this was that failover to other datacenters should be a rare occurrence. And these failover datacenters could also be very remote. So expensive calls to remote datacenters should be as rare as possible.

d4c4nf3 avatar Apr 24 '21 07:04 d4c4nf3