spring-cloud-consul icon indicating copy to clipboard operation
spring-cloud-consul copied to clipboard

add acl-token to ttl

Open varnson opened this issue 6 years ago • 10 comments

resubmit for #571 to fix #559 . @spencergibb I'm sorry for a new PR.

varnson avatar Sep 20 '19 10:09 varnson

@spencergibb Do you have a plan to merge this PR?

varnson avatar Sep 24 '19 12:09 varnson

Hello What about this PR ? I always have a 403 : http: Request PUT /v1/agent/check/pass/service:casconfigserver-8888, error: Permission denied Thanks.

kevinimbrechts avatar Nov 29 '19 09:11 kevinimbrechts

There are ci errors, and I think the sleep is too short in the remove test. But I do not know how to trigger the ci again.

varnson avatar Nov 30 '19 02:11 varnson

Not sure what to do, tests continue to fail.

spencergibb avatar Jan 13 '20 21:01 spencergibb

@spencergibb The ci error is "This job has been blocked because resource-class:large is not available on your plan. Please upgrade to continue building.", not compile error or test error.

varnson avatar Jan 14 '20 23:01 varnson

You have to

$ git rebase -i master
$ git push --force

to pick up this change https://github.com/spring-cloud/spring-cloud-consul/commit/5118afce4f96d9e9bba63f03cc73452877300ae4

spencergibb avatar Jan 15 '20 00:01 spencergibb

This old issue, how is it still not repaired? Do you need to wait? @spencergibb What can I help?

chenzhiguo avatar Sep 13 '21 05:09 chenzhiguo

I think this is a very serious bug, should not be dragged for so long. Although I can fix it by extents.

chenzhiguo avatar Sep 15 '21 16:09 chenzhiguo

这个bug需要赶紧修复了。大哥们。

chenjinkai avatar Jan 21 '22 06:01 chenjinkai

Hello guys, do you plan to fix this bug?

TimurDaas avatar Sep 21 '22 23:09 TimurDaas

3 years, this problem is still.... i wonder why

jefflaifu avatar Oct 26 '22 08:10 jefflaifu

Hi! As you probably know, this PR introduces some breaking changes. Our academic tool, BreakBot, helps developers better assess the impact of these changes on client projects. BreakBot checked the top 100 most starred clients of spring-cloud-consul on GitHub and found out that only one is impacted by one of the breaking changes.

You can find the full BreakBot report in our fork repository breakbot-playground/spring-cloud-consul.

We hope this information about the impact of this PR's changes is valuable to you, and apologize otherwise. If you're willing to help, we would kindly ask for your help to fill in a 5-minutes survey about the report. Your feedback will help us improve the tool and help us in our research!

lmove avatar Nov 30 '22 12:11 lmove

3 years, this problem is still.... i wonder why

There is no reason, because technology is really rubbish! Four years of bugs, think about it

mmm8955405 avatar Mar 15 '23 08:03 mmm8955405

This was fixed in 226e08a8eb4cb77ee36861195a234020ee12d665

spencergibb avatar Mar 15 '23 18:03 spencergibb

这已在226e08a中修改

Is there any release version available? If you submit code and then close the bug, have you tried testing or released an available version. Version 4.0.1 still fails

mmm8955405 avatar Mar 17 '23 01:03 mmm8955405

这已在226e08a中修改

Can you teach me how to introduce the main branch from maven? The main branch reference

mmm8955405 avatar Mar 17 '23 01:03 mmm8955405

Main will be released in two weeks. See https://github.com/spring-cloud/spring-cloud-release/milestones?direction=asc&sort=due_date&state=open

spencergibb avatar Mar 17 '23 02:03 spencergibb