spring-cloud-consul icon indicating copy to clipboard operation
spring-cloud-consul copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Modify the getServices() method so that it filters on default-query-tag

Open fuleow opened this issue 6 years ago • 5 comments

This PR modifies ConsulDiscoveryClient so that its getServices() method takes into account the value of default-query-tag if it is set.

Further details are available in issue #452.

fuleow avatar Sep 19 '18 23:09 fuleow

@fuleow Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

pivotal-issuemaster avatar Sep 19 '18 23:09 pivotal-issuemaster

Do changes of these nature fall under "obvious fix" or does it require signing the ICLA?

fuleow avatar Dec 17 '18 05:12 fuleow

Since it is a change in functionality or behavior, it requires the CLA

spencergibb avatar Dec 17 '18 05:12 spencergibb

@fuleow Thank you for signing the Contributor License Agreement!

pivotal-issuemaster avatar Jan 14 '19 22:01 pivotal-issuemaster

In Finchley, this method is useless, I don't know why catalogservice was called frequently.

varnson avatar Jun 13 '19 00:06 varnson