spring-cloud-config icon indicating copy to clipboard operation
spring-cloud-config copied to clipboard

Published 20 hours ago • verified publisher icon spring-cloud

Ensure last-wins profile order is respected for AWS Parameter Store and Secrets Manager

Open driseley opened this issue 1 year ago • 1 comments

Fixes #2385

Note, for Secrets Manager this fix breaks existing tests, which I have corrected. I don't think the existing tests assert the correct expected profile order, so these have been updated to reflect the changed logic. However I don't know if this counts as a breaking change?

Also, I would be very grateful, if this is accepted, if it could be backported to the 4.0.x branch as this is the version we are currently using and where it affects us.

driseley avatar Feb 16 '24 15:02 driseley

Fixed checkstyle issue and force pushed

driseley avatar Feb 16 '24 17:02 driseley

@spencergibb - is it possible to get the build for this PR rerun? Many thanks

driseley avatar Feb 27 '24 07:02 driseley

Thanks for the PR @driseley. The 4.0.x branch is no longer supported so we will not be cherry picking the PR back to that branch because there will not be any more open source releases of that branch.

ryanjbaxter avatar Mar 12 '24 19:03 ryanjbaxter