change to package level, since it's used only it tests fix related t…

[avnerstr]

…o issue #1896

[avnerstr]

@ryanjbaxter something looks weird. Suddenly all my builds breaks. Even when I just fork without adding new code. for example: Caused by: org.springframework.beans.factory.BeanCurrentlyInCreationException: Error creating bean with name 'org.springframework.cloud.config.server.environment.vault.SpringVaultClientConfiguration': Requested bean is currently in creation: Is there an unresolvable circular reference?

any idea? please help !!

[ryanjbaxter]

I just realized this change was made in main and not in the 2.2.x branch. There was a change to the way circular references were detected in Spring Boot that broke us. I will need to look into that, but its unrelated to this change.

Is there a reason why these changes shouldn't be made in the 2.2.x branch?

[avnerstr]

@ryanjbaxter - I guess you mean - shouldn't ? if that right, I don't see reason why not. It can be merged to all branches.

What do I need to do in order to make my build work again. Now even clean fork breaks.

[ryanjbaxter]

Create a PR against 2.2.x, that branch should be fine. I will merge it and merge it into main. There is nothing you can do about making main build until we figure out the circular reference.

[codecov[bot]]

Codecov Report

Merging #1950 (20b10c4) into main (1f71006) will increase coverage by 0.01%. The diff coverage is 100.00%.

@@             Coverage Diff              @@
##               main    #1950      +/-   ##
============================================
+ Coverage     76.45%   76.46%   +0.01%     
- Complexity     1408     1410       +2     
============================================
  Files           182      182              
  Lines          5321     5324       +3     
  Branches        704      704              
============================================
+ Hits           4068     4071       +3     
  Misses          986      986              
  Partials        267      267              

Impacted Files	Coverage Δ
.../server/environment/JGitEnvironmentRepository.java	87.75% <100.00%> (+0.04%)	:arrow_up:
...ment/MultipleJGitEnvironmentRepositoryFactory.java	72.72% <100.00%> (+2.72%)	:arrow_up:

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1f71006...20b10c4. Read the comment docs.

[ryanjbaxter]

The build is now passing, but I would still suggest we submit this to the 2.2.x. branch

[avnerstr]

@ryanjbaxter I'm working on that right now

[avnerstr]

@ryanjbaxter I see that you didn't insert your fix: Make GitCredentialsProviderFactory a bean. Fixes #1896 (#1926) to branch 2.2.x and my fix depends on it. Can you do it?

[ryanjbaxter]

Im sorry im getting my projects/branches confused, submit the pr to the 3.0.x branch.

[ryanjbaxter]

Already addressed in https://github.com/spring-cloud/spring-cloud-config/pull/1926