spring-cloud
Switch remaining jUnit 4 tests to jUnit jupiter
Hello @spencergibb, Can I take this up if nobody is working on it already? Thanks in advance!
@ManasviGoyal is working on reducing method and class visibility after the conversion to JUnitJupiter.
Gave it a quick try to convert more classes over to JUnit 5; outcome here: https://github.com/spring-cloud/spring-cloud-commons/compare/main...timtebeek:increase-junit-platform-usage This is mostly the result of applying the JUnit4 to 5 conversion from OpenRewrite.
I had not yet created a merge request (although willing) as it appeared @ManasviGoyal was also working on this previously, and I don't know the current state of that effort.
I had dropped the Adhoc suites for now, as they are ignored currently, and converting them to disabled suites would require additional depencies. Please let me know if these should be restored as they were or converted with the added dependencies.
There's quite a few tests left over that rely on the ModifiedClassPathRunner; is anyone aware of a similar mechanism for JUnit Jupiter? I'm aware of the FilteredClassLoader when testing Auto-configuration, but I don't know it that would be applicable here.
@timtebeek, @spencergibb is currently working on an alternative to the ModifiedClassPathRunner for JUpiter. We'll update here once that's done.
Any replacement for the ModifiedClassPathRunner could also help complete the Jupiter migration in https://github.com/spring-cloud/spring-cloud-gateway/pull/2387, so mentioning that here to have a feedback loop back to that issue as well.
yes, I have local branch with a copy, but there are errors I haven't had time to work thru.